ScanNext & ScanZone fixes #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move scan dialog into its own component - Move constants out of ScanNextTarget fn - Wrap a lot of state changes in useEffects to control renders
- Consolidate repeat functions - Consolidate repeat dialog
- Consolidate ScanNext and ScanZone components into one reusable component - Cleanup backend code to use more general variables -
- Use styled components instead of theme overrides - Remove unnecessary Slider props and use React Children instead of passing a block prop - Disable other map markers when ScanZone popup is open, something is not right when any other markers are activated that can cause the server to get hammered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe resolves #555