Bring back map markers when using scanZone #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurtIeSocks
approved these changes
Jul 18, 2023
Collaborator
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
I have concerns about usability in some scenarios but I can't seem to replicate the issue that was the original reason for adding this line so I'll approve and revisit if the issue pops up again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #580 map markers were disabled on scanZone feature due to performance issues. I think we're past these issues so we can bring markers back.
I ran some tests locally on desktop and mobile and I hardly can see any difference when using map with markers or map with markers and scanZone on top
Btw I hope that's the only change that needs to be done ;)