Size Proto Support#622
Closed
TurtIeSocks wants to merge 9 commits intodevelopfrom
Closed
Conversation
- Adds a few translation keys - Moves all "old size" reference to height - New size reference is the size proto - Maintains backwards compatibility - Filter size globally and per pokemon - Adds map marker indicator to view the size of the pokemon - Requires updates from those using custom pokemon markers - Version bump
Fabio1988
reviewed
Dec 16, 2022
| display_pokemon_id: Int | ||
| ditto_form: Int | ||
| weight: Float | ||
| height: Float |
Contributor
There was a problem hiding this comment.
height is Float, size Int..?!
Collaborator
Author
There was a problem hiding this comment.
Maintains backwards compatibility for now, since size for everyone not using the latest rdm is still going to be a float ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires RealDeviceMap/RealDeviceMap#456