Skip to content

Include Kacleon Stops in Event Stops#632

Merged
TurtIeSocks merged 2 commits intoWatWowMap:mainfrom
ccev:patch-3
Jan 7, 2023
Merged

Include Kacleon Stops in Event Stops#632
TurtIeSocks merged 2 commits intoWatWowMap:mainfrom
ccev:patch-3

Conversation

@ccev
Copy link
Copy Markdown
Contributor

@ccev ccev commented Jan 7, 2023

This should change the event stop query so that it includes all display types >= 7. Right now this only includes the Coin and Kacleon Stops. This is assuming that future event stops work the same way.

Untested

@kamieniarz
Copy link
Copy Markdown
Contributor

kamieniarz commented Jan 7, 2023

Doesn't work for me :( I mean it kinda works - I had to enable all stops and invasions to see these special ones

@ChaosEmpire
Copy link
Copy Markdown

Working fine...like the Golden Copins..so it display orange Stops (not kecleon)

@nileplumb
Copy link
Copy Markdown

Not working here really sadly

@Pogodenhelder
Copy link
Copy Markdown

tried it as well, and it didnt work...

@lenisko
Copy link
Copy Markdown
Contributor

lenisko commented Jan 7, 2023

Can't check now, but it's most likely connected to filtering https://github.com/WatWowMap/ReactMap/blob/develop/server/src/models/Pokestop.js#L588-L597

@Pogodenhelder
Copy link
Copy Markdown

Schermafbeelding 2023-01-07 om 20 08 35
this is how it looks on the map.
The golden coin or how it looks like and the timer most likely gives it away.. but im not sure.

@nileplumb
Copy link
Copy Markdown

nileplumb commented Jan 7, 2023

Ideally it should start looking at uicons for_i8 stops I already populated my repos with them

@nileplumb
Copy link
Copy Markdown

F9A2F326-DA9E-4CA6-9B63-210E5D5EEA72

@Ninjasoturi
Copy link
Copy Markdown
Contributor

https://github.com/ninjasoturi/ReactMap/tree/kecleo
Dirty fix until some actual programmer can come up with a better one

- fix NaN issue
- show kecleon in pokestop popup
Copy link
Copy Markdown
Collaborator

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Made some fixes, working now.

@TurtIeSocks TurtIeSocks merged commit 2c979cc into WatWowMap:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants