running "!RemindMe 29 april FOO" on 24 april causes it to wait 1 year...

[divinity76]

seems to be 1 year off here..

[Watchful1]

Can't reproduce

maybe it was something to do with the link? You can put links in square brackets [] to exclude them from the parsing, like

!RemindMe 29 April [https://mail.google.com]

and then it will send you that link instead of the link to your message. But it will also exclude the link from the date parsing, which might be causing the issue here.

[divinity76]

@Watchful1 try
!RemindMe 29 April https://mail.google.com/mail/u/0/#inbox/FMfcgzGpFWSCZFtGNptZnqxLmJPKFSNx

[Watchful1]

Yeah, it must be picking up the 0 in the link and it's messing up the parsing somehow. If you do

!RemindMe 29 April [https://mail.google.com/mail/u/0/#inbox/FMfcgzGpFWSCZFtGNptZnqxLmJPKFSNx]

with square brackets that excludes it and it works. There's not much I can do about it, I just pass the string into a date parsing library and it spits out the result.

[divinity76]

@Watchful1 well i have never seen a date string containing "http", i suspect that cutting the string at the first occurrence of "http" before sending it to the date parsing library would be an improvement. But which date parsing library are you using? Perhaps complaining on that date parsing library's bugtracker could be worthwhile too

[Watchful1]

Sorry for the delay, I'll take a look at stopping parsing before "http". I need to do some comparisons to see if it causes any unexpected other changes. I'll probably do it differently than your pull request.

I use dateparser first and then parsedatetime if the first doesn't find anything. Neither are really intended to extract dates from strings that include things other than dates, so they are much more likely to be over eager in extracting things than not.

[divinity76]

same problem with

!RemindMe 27 august https://github.com/php/php-src/issues/9026

... i sent that 18 agust and the response i got was

I will be messaging you in 1 year on [2023-08-18 00:00:00 UTC](http://www.wolframalpha.com/input/?i=2023-08-18%2000:00:00%20UTC%20To%20Local%20Time) to remind you of [this link](https://www.reddit.com/message/messages/1golv7x)

[divinity76]

still think PR #10 would fix both.

[divinity76]

same problem with

!RemindMe 27 august aHR0cHM6Ly9naXRodWIuY29tL3BocC9waHAtc3JjL2lzc3Vlcy85MDI2

however PR #10 would not fix this case

[Watchful1]

Added http to the regex in find_reminder_time which should fix that case c74dcf9