chore(precheck): log vox-invocation failures#624
Merged
Conversation
af16eeb to
e555dd8
Compare
Replace the implicit `vox ... || true` swallow shape with an instrumented pattern that captures rc + stderr and emits a `vox_invocation_failed` event to mcp.jsonl on non-zero exit. The `vox` ALWAYS-called rule and best-effort semantics are unchanged - vox failure does not block the precheck gate. The skill now documents the canonical bash pattern and a checklist status line that distinguishes vox success vs. failure visually. Pairs with cc-workflow#551 (vox-script-side instrumentation): - vox_invocation_failed (this PR) — vox didn't run / returned non-zero - call_failed (cc#551) — vox ran but provider/player failed Closes #550 Plan: #607 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
e555dd8 to
51da0ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces silent
|| trueswallow on /precheck's vox invocation with structuredmcp-logfailure event per cc-workflow#550.Closes #550
Wave 5a / Flight 1 of Plan #607 (Beta).