Conversation
soreau
requested changes
Mar 26, 2025
Member
soreau
left a comment
There was a problem hiding this comment.
Overall your patch seems pretty straightforward. To pass CI, you will need to change json packages as in this commit and apply the diff from the uncrustify check. Aside from minor changes needed, it looks good to me. 👍
Contributor
Author
|
I think uncrustify should be happy with the style now. I haven't been able to run it myself, but it seems like it just wanted the = signs to align. I also changed the json package in the CI, so that should work now I think. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should update the plugins relying on json to match the switch to yyjson from the wayfire master branch. I also have changes for the filters submodule locally, but I can't figure out how to include them.
I called the variables for the optionals maybe_x and maybe_y, but maybe there's a nicer way to fix this.