Add "Fill and Crop" option for wf-background. Pt 2 #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammen99
approved these changes
Apr 3, 2024
Member
ammen99
left a comment
ammen99
left a comment
There was a problem hiding this comment.
Tested and seems to work, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt strongly about #58 so I replicated the fork against master and followed the requested changes.
After some testing with a variety of images and screens I made further edits:
image_scalevalue that gets passed into the render logic for each imageThese were necessary as loading tall images in ultrawide screens or visa-versa caused a crash from attempting to create a Pixbuf that was too large.
I have attempted to stick to the coding style of the project but feel free to correct me on it.