panel : battery : only show power mode popover if it is available and replace the icon with a power icon if the device doesn’t have a battery#473
Merged
Conversation
AKArien
changed the title
do not connect open_on if the power-profiles-daemon interface is not found, thus not letting the user open an empty popover, which wuold be jarring
… available use the power icon corresponding to the current state if the device doesn’t have a battery but power profiles switching is available if neither are available, still ignore the widget
panel: fix first icon being invaid for machines without system battery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not connect open_on if the power-profiles-daemon interface is not found, thus not letting the user open an empty popover, which would be jarring
use the power icon corresponding to the current state if the device doesn’t have a battery but power profiles switching is available
if neither are available, still ignore the widget