Skip to content

Disable udta Parsing #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kevin-McGonigle merged 1 commit into from
Apr 3, 2023
Merged

Disable udta Parsing #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.4.5
* Disable `udta` ISOBMFF box parsing, since their contents are not guaranteed to be consistent with the spec.

## 2.4.4
* Prevent infinite loops when parsing ISOBMFF boxes with size = 0 (meaning that the box extends to the end of the file).

Expand Down
2 changes: 1 addition & 1 deletion lib/format_parser/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module FormatParser
VERSION = '2.4.4'
VERSION = '2.4.5'
end
2 changes: 1 addition & 1 deletion lib/parsers/iso_base_media_file_format/decoder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def build_box_tree(max_read, io = nil)
'trak' => :container,
# 'trex' => :trex,
# 'tsel' => :tsel,
'udta' => :container,
# 'udta' => :container,
# 'url ' => :dref_url,
# 'urn ' => :dref_urn,
'uuid' => :uuid,
Expand Down