Skip to content

Improving I/O consumption for TIFF-based formats #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcpalacio merged 2 commits into from
May 31, 2023
Merged

Improving I/O consumption for TIFF-based formats #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09d70f1
Upgrading EXIFR in order to skip reading JPEG thumbnails for TIFF bas…
May 30, 2023
ff671fb
Bumping version and writing changelog
May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.6.0
* Prevent the default loading of thumbnails on TIFF-based formats to improve I/O.

## 2.5.0
* Add `avc1` and `xavc` as brand codes in the mp4 format parser to allow more file types to be parsed correctly.

Expand Down
2 changes: 1 addition & 1 deletion format_parser.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_dependency 'exifr', '>= 1.3.8'
spec.add_dependency 'exifr', '>= 1.4.0'
spec.add_dependency 'id3tag', '>= 0.14.2'
spec.add_dependency 'matrix'
spec.add_dependency 'measurometer'
Expand Down
2 changes: 1 addition & 1 deletion lib/format_parser/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module FormatParser
VERSION = '2.5.0'
VERSION = '2.6.0'
end
2 changes: 1 addition & 1 deletion lib/parsers/exif_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def method_missing(*a)
def exif_from_tiff_io(constrained_io, should_include_sub_ifds = false)
Measurometer.instrument('format_parser.exif_parser.exif_from_tiff_io') do
extended_io = IOExt.new(constrained_io)
exif_raw_data = EXIFR::TIFF.new(extended_io)
exif_raw_data = EXIFR::TIFF.new(extended_io, load_thumbnails: false)
Copy link
Copy Markdown
Contributor

@linkyndy linkyndy May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: could it be useful to provide this as a config for the library? I can imagine some might actually need those thumbnails.

Copy link
Copy Markdown
Contributor Author

@rcpalacio rcpalacio May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean via intrinsics? That is a good point. I'll change this.
On this: are the intrinssics something we want to maintaining stable across multiple versions?

Copy link
Copy Markdown
Contributor

@linkyndy linkyndy May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, just a way to configure this when using the library.

On the intrinsics, I think it would be nice, though I wouldn't consider it as a priority.


return unless exif_raw_data

Expand Down