Conversation
added 11 commits
June 22, 2023 14:03
linkyndy
reviewed
Jun 27, 2023
|
Could you also update the README and up the version in |
linkyndy
reviewed
Jun 27, 2023
enricoribelli
approved these changes
Jun 27, 2023
| rescue Validator::JSONParserError | ||
| nil | ||
| end | ||
| FormatParser.register_parser new, natures: :text, formats: :json |
There was a problem hiding this comment.
to double check: when priority is not specified it means that it goes 'last' or let's say random with respect to ordered-through-priority parsers, right?
Contributor
Author
There was a problem hiding this comment.
That's a good point. The default priority is 99, which means a parser gets the least priority unless a priority is set explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new parser to support JSON files.
The new parser tries to validate the JSON syntax in a file without actually parsing and loading a JSON object in memory for both performance and security reasons.