Skip to content

Allow backticks in gh-ost query#71

Merged
acroos merged 2 commits intomainfrom
fix/stop-cleaning-backticks
Mar 30, 2022
Merged

Allow backticks in gh-ost query#71
acroos merged 2 commits intomainfrom
fix/stop-cleaning-backticks

Conversation

@acroos
Copy link
Copy Markdown
Contributor

@acroos acroos commented Mar 30, 2022

Description

Backticks are needed if any columns, tables, etc have names that are MySQL reserved keywords.

Fixes #70

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests have been updated and I've run a migration locally with a column named interval

Checklist:

  • My code follows the style guidelines set by rubocop
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@acroos acroos requested review from idanci, nickdowse and roysab March 30, 2022 12:02
@acroos acroos self-assigned this Mar 30, 2022
@acroos acroos merged commit 3f278fc into main Mar 30, 2022
@acroos acroos deleted the fix/stop-cleaning-backticks branch March 30, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow reserved keywords to be used by wrapping in backticks

2 participants