Dev by dangthang1903 · Pull Request #8 · Weaverse/aspen

dangthang1903 · 2025-07-10T10:00:16Z

Summary by CodeRabbit

New Features
- Introduced a quick shop drawer interface with enhanced product details, accordion sections, and zoomable product images.
- Added customizable quick shop settings, including button texts and compare-at price visibility, in theme configuration.
- Added new components for streamlined variant and option selection in quick shop.
Refactor
- Unified product option selection into a consistent dropdown with swatch/image previews.
- Replaced modal-based quick shop with a Radix UI Dialog-based drawer for improved user experience.
Bug Fixes
- Improved cart session handling to ensure reliable cart updates and compatibility with React Router v7.
- Polyfilled header handling to support multiple Set-Cookie headers.
Style
- Updated layouts and spacing for cart, footer, product options, and quantity selector for improved visual consistency.
- Enhanced product information and details sections with clearer price displays and structured content.

… to maintain consistency and improve clarity

…g in footer component elements

…7 compatibility and adjust class styling in cart components

…er UI consistency and user interaction across product options

coderabbitai · 2025-07-10T10:00:25Z

📝 Walkthrough

Walkthrough

This update introduces a comprehensive refactor of the quick shop and product variant selection UI, replacing modal-based flows with Radix Dialog drawers and unifying option selectors. It also implements a manual session cookie management workaround for cart-related routes due to React Router v7 compatibility issues. Additional enhancements include new theme schema settings for quick shop customization, polyfills for multi-cookie header support, and various UI and styling adjustments.

Changes

Files/Groups	Change Summary
`app/components/cart/cart.tsx` `app/components/layout/cart-drawer.tsx` `app/components/layout/footer.tsx` `app/components/link.tsx` `app/components/product/quantity.tsx` `app/components/product/variants.tsx`	Minor CSS and class name adjustments for layout, spacing, and styling.
`app/components/product/product-card-options.tsx`	Removed unused imports (`cn`, `isValidColor`).
`app/components/product/product-option-values.tsx`	Refactored to always render options as a dropdown; unified swatch/image preview logic; removed legacy UI patterns and arrays; updated exports.
`app/components/product/quick-shop-option-values.tsx`	Added new `QuickShopOptionValues` component for option selection with swatch/image previews and dropdown UI.
`app/components/product/quick-shop-variants.tsx`	Added new `QuickShopVariants` component for rendering product variant selectors in quick shop.
`app/components/product/quick-shop.tsx`	Major refactor: replaced modal with Radix Dialog drawer, added `ProductDetailsContent` and `ProductDescriptionDrawer`, improved variant state, price display, and loading/error handling.
`app/routes/($locale).cart.$lines.tsx` `app/routes/($locale).cart.add.$variantId.ts` `app/routes/($locale).cart.tsx` `app/routes/($locale).discount.$code.tsx`	Updated cart/session ID management to use manual session cookie handling instead of `cart.setCartId()` due to React Router v7 issues.
`app/sections/product-information/index.tsx`	Removed `showShortDescription` logic and schema; restructured price section; simplified fallback rendering.
`app/sections/product-information/product-details.tsx`	Added product summary as an accordion item in product details.
`app/weaverse/schema.server.ts`	Added new "Quick shop" settings group for theme customization (zoom, button text, compare-at price toggle).
`server.ts`	Polyfilled `Headers` prototype to support multiple `Set-Cookie` headers for React Router v7 compatibility.

Sequence Diagram(s)

Quick Shop Drawer Flow

sequenceDiagram
    participant User
    participant QuickShopTrigger
    participant QuickShop (Drawer)
    participant QuickShopVariants
    participant QuickShopOptionValues
    participant ProductDescriptionDrawer

    User->>QuickShopTrigger: Clicks "Quick Shop"
    QuickShopTrigger->>QuickShop: Opens drawer, fetches product data
    QuickShop->>QuickShopVariants: Renders variant selectors
    QuickShopVariants->>QuickShopOptionValues: Renders dropdowns with swatches/images
    User->>QuickShopOptionValues: Selects option value
    QuickShopOptionValues->>QuickShop: Updates selected variant
    User->>QuickShop: Clicks "View Description"
    QuickShop->>ProductDescriptionDrawer: Opens description drawer with accordion details

Cart Session Cookie Handling (Simplified)

sequenceDiagram
    participant RouteLoader
    participant Session
    participant Headers

    RouteLoader->>Session: set("cartId", newCartId)
    RouteLoader->>Session: commit()
    Session-->>RouteLoader: Set-Cookie header value
    RouteLoader->>Headers: set("Set-Cookie", value)
    RouteLoader->>Client: Responds with headers (including Set-Cookie)

Poem

🛒✨
A bunny hopped into the shop,
With drawers that slide and swatches that pop.
Cookies set with extra care,
So carts and discounts travel fair.
Quick shop settings, oh what fun—
Now every product shines like the sun!
Hooray for code, the update’s done!

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

app/components/product/quick-shop-option-values.tsx (1)

82-87: Use optional chaining for cleaner code.

Apply this change to use optional chaining:

-          const found = optionValues.find(({ name: value }) => value === v);
-          if (found && found.firstSelectableVariant?.id) {
-            onVariantChange(found.firstSelectableVariant.id);
-          }
+          const found = optionValues.find(({ name: value }) => value === v);
+          if (found?.firstSelectableVariant?.id) {
+            onVariantChange(found.firstSelectableVariant.id);
+          }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d20c83 and d595e12.

📒 Files selected for processing (19)

app/components/cart/cart.tsx (1 hunks)
app/components/layout/cart-drawer.tsx (1 hunks)
app/components/layout/footer.tsx (5 hunks)
app/components/link.tsx (1 hunks)
app/components/product/product-card-options.tsx (1 hunks)
app/components/product/product-option-values.tsx (3 hunks)
app/components/product/quantity.tsx (1 hunks)
app/components/product/quick-shop-option-values.tsx (1 hunks)
app/components/product/quick-shop-variants.tsx (1 hunks)
app/components/product/quick-shop.tsx (1 hunks)
app/components/product/variants.tsx (1 hunks)
app/routes/($locale).cart.$lines.tsx (2 hunks)
app/routes/($locale).cart.add.$variantId.ts (2 hunks)
app/routes/($locale).cart.tsx (2 hunks)
app/routes/($locale).discount.$code.tsx (2 hunks)
app/sections/product-information/index.tsx (3 hunks)
app/sections/product-information/product-details.tsx (1 hunks)
app/weaverse/schema.server.ts (1 hunks)
server.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

`**/*.{js,jsx,ts,tsx}`: Replace all imports from Remix packages with their equiv...

**/*.{js,jsx,ts,tsx}: Replace all imports from Remix packages with their equivalent React Router v7 packages as specified in the provided mapping table.
NEVER use 'react-router-dom' imports in this Hydrogen project.
When generating new code or modifying existing code, ensure all routing-related imports come from the correct React Router packages.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/hydrogen-react-router.mdc)