Skip to content

Refactor/to scss search bar#254

Merged
Satoshi-Sh merged 5 commits intomainfrom
refactor/to-scss-SearchBar
Jul 14, 2025
Merged

Refactor/to scss search bar#254
Satoshi-Sh merged 5 commits intomainfrom
refactor/to-scss-SearchBar

Conversation

@Satoshi-Sh
Copy link
Copy Markdown
Member

Web Dev Path
238

Have you updated the CHANGELOG.md file? If not, please do it.

Yes

What is this change?

  • CSS modules migration for SearchBar component
  • Changed the searchbar input width

Before:

Screenshot from 2025-07-12 09-28-50

After:

Screenshot from 2025-07-12 09-36-22

If necessary, please describe how to test the new feature or fix.

Please check SearchBar styling on the blog page.

When should this be merged?

After review

@Satoshi-Sh Satoshi-Sh requested a review from a team July 12, 2025 14:39
@Satoshi-Sh Satoshi-Sh self-assigned this Jul 12, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit c6e5cb9
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/68751e4b67d9850008cd5c3d
😎 Deploy Preview https://deploy-preview-254--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles.js file can be deleted.

@Satoshi-Sh Satoshi-Sh force-pushed the refactor/to-scss-SearchBar branch from 79fc730 to 5627e3c Compare July 14, 2025 10:53
@Satoshi-Sh Satoshi-Sh requested a review from oluwatobiss July 14, 2025 10:54
Copy link
Copy Markdown
Member

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, works fine.

Copy link
Copy Markdown
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great! Thanks @Satoshi-Sh.

Copy link
Copy Markdown
Member

@briangesteban briangesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @Satoshi-Sh !

@Satoshi-Sh Satoshi-Sh merged commit df725c2 into main Jul 14, 2025
3 of 4 checks passed
@Satoshi-Sh Satoshi-Sh deleted the refactor/to-scss-SearchBar branch July 14, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants