Skip to content

Refactor/to-scss-related-posts#256

Merged
briangesteban merged 8 commits intomainfrom
refactor/to-scss-RelatedPosts
Aug 12, 2025
Merged

Refactor/to-scss-related-posts#256
briangesteban merged 8 commits intomainfrom
refactor/to-scss-RelatedPosts

Conversation

@briangesteban
Copy link
Copy Markdown
Member

Web Dev Path
238

Have you updated the CHANGELOG.md file? If not, please do it.

Yes

What is this change?

Migrate RelatedPosts component from styled-components to SCSS module.

Were there any complications while making this change?

None

How to replicate the issue?

N/A

If necessary, please describe how to test the new feature or fix.

N/A

When should this be merged?

After reveiws.

Image Reference

ref-relatedPost

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 15, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit 6b9a6b5
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/68997842aac24e000889de30
😎 Deploy Preview https://deploy-preview-256--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@briangesteban briangesteban requested a review from a team July 15, 2025 15:15
Comment thread components/blog/RelatedPosts/RelatedPosts.module.scss
Copy link
Copy Markdown
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the anchor font’s responsiveness, @briangesteban. Please consider the additional suggestions I’ve made.

Comment thread styles/_variables.scss Outdated
Comment thread styles/_typography.scss Outdated
Copy link
Copy Markdown
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you for your efforts on this.

@Satoshi-Sh
Copy link
Copy Markdown
Member

Looks good overall. Thanks for refactoring.

Member.modules.scss
.name {
  font-style: italic;
  font-family: $heading-font;
  font-size: 1.5rem;
  color: var(--color-primary-content);
  margin-bottom: 0px;
  line-height: unset;
}

%headingStyle {
  font-family: $heading-font;
  font-size: 1rem;
  color: var(--color-primary-content);
  text-align: left;
  line-height: normal;
  margin: 0px;
}

$heading-font need to be updated here.

@Satoshi-Sh Satoshi-Sh self-requested a review August 8, 2025 10:38
@briangesteban
Copy link
Copy Markdown
Member Author

Looks good overall. Thanks for refactoring.

Member.modules.scss
.name {
  font-style: italic;
  font-family: $heading-font;
  font-size: 1.5rem;
  color: var(--color-primary-content);
  margin-bottom: 0px;
  line-height: unset;
}

%headingStyle {
  font-family: $heading-font;
  font-size: 1rem;
  color: var(--color-primary-content);
  text-align: left;
  line-height: normal;
  margin: 0px;
}

$heading-font need to be updated here.

Thanks for the review @Satoshi-Sh. I've updated the Member.modules.scss font stylings to align with the current change

Copy link
Copy Markdown
Member

@Satoshi-Sh Satoshi-Sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loogs good to me. Thanks for the update

@briangesteban briangesteban merged commit 7e7c687 into main Aug 12, 2025
4 checks passed
@briangesteban briangesteban deleted the refactor/to-scss-RelatedPosts branch August 12, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants