Refactor/to scss member#257
Merged
Satoshi-Sh merged 4 commits intomainfrom Jul 18, 2025
Merged
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cherylli
requested changes
Jul 16, 2025
Member
cherylli
left a comment
cherylli
left a comment
There was a problem hiding this comment.
I didn't comment on all the !important but I think this file as way too many !important. I know it's copied from the styles but maybe we should see if we can remove most if not all of the !important
Satoshi-Sh
force-pushed
the
refactor/to-scss-Member
branch
from
6749618 to
e7be205
Compare
shayla-develops-webs
approved these changes
Jul 17, 2025
Member
shayla-develops-webs
left a comment
shayla-develops-webs
left a comment
There was a problem hiding this comment.
Looks good Satoshi!
oluwatobiss
reviewed
Jul 18, 2025
Member
oluwatobiss
left a comment
oluwatobiss
left a comment
There was a problem hiding this comment.
Why don’t we stick with camelCasing as @cherylli recommended on Slack?
oluwatobiss
approved these changes
Jul 18, 2025
Member
oluwatobiss
left a comment
oluwatobiss
left a comment
There was a problem hiding this comment.
All looks great! Thanks @Satoshi-Sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you updated the CHANGELOG.md file? If not, please do it.
Yes
What is this change?
CSS modules migration for Member component
If necessary, please describe how to test the new feature or fix.
Please check the member part stylings on About page.
When should this be merged?
After review