Skip to content

Refactor/to scss container#258

Merged
Satoshi-Sh merged 4 commits intomainfrom
refactor/to-scss-Container
Jul 21, 2025
Merged

Refactor/to scss container#258
Satoshi-Sh merged 4 commits intomainfrom
refactor/to-scss-Container

Conversation

@Satoshi-Sh
Copy link
Copy Markdown
Member

Web Dev Path
238

Have you updated the CHANGELOG.md file? If not, please do it.

Yes

What is this change?

  • CSS modeeuls migration for Container
  • Additionally, I updated Member as I'd noticed the $heading-font was defined in _variables.scss

If necessary, please describe how to test the new feature or fix.

Please check the place Container used

Screenshot from 2025-07-19 08-15-50

When should this be merged?

After review

@Satoshi-Sh Satoshi-Sh requested a review from a team July 19, 2025 13:17
@Satoshi-Sh Satoshi-Sh self-assigned this Jul 19, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 19, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit 5b0f869
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/687c43450023f60008d7497c
😎 Deploy Preview https://deploy-preview-258--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread components/containers/Container/index.js Outdated
Comment thread components/containers/Container/index.js Outdated
Copy link
Copy Markdown
Member

@shayla-develops-webs shayla-develops-webs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as-is since it works perfectly and isn’t a blocking issue.
Just a heads-up for next time: using the prop name style (without underscore) would align better with React’s standard conventions for inline styles and improve clarity for future maintainers.
Thanks for the solid work on this!

Copy link
Copy Markdown
Member

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Satoshi-Sh Satoshi-Sh merged commit ff32287 into main Jul 21, 2025
4 checks passed
@Satoshi-Sh Satoshi-Sh deleted the refactor/to-scss-Container branch July 21, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants