Refactor/to scss layout#273
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
can we delete the styles.js file in the same folder now? |
Thanks. Deleted. |
oluwatobiss
left a comment
There was a problem hiding this comment.
Do we need this rule at all? It looks to be doing nothing.
I didn't notice this. I also checked the styling without the rules, and the web site seems the same. |
It has no impact on all the pages I’ve checked. However, even if it does, it seems odd to change the stacking context of the website’s main container. It can make debugging challenging. This case of uncertainty about whether the rule has any side effects is a good example of the unintended consequences that such implementation can cause. Since we are working on the style conversion, it may be best to delete it now so we can determine its impact as we progress. |
oluwatobiss
left a comment
There was a problem hiding this comment.
All looks good. Thanks @Satoshi-Sh!
Have you updated the CHANGELOG.md file? If not, please do it.
Yes
What is this change?
CSS modules migration for Layout component
If necessary, please describe how to test the new feature or fix.
Please check the main styling on any page.
When should this be merged?
After reviews