Refactor/to scss cardcolumns#279
Merged
oluwatobiss merged 9 commits intomainfrom Aug 22, 2025
Merged
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Satoshi-Sh
approved these changes
Aug 20, 2025
Member
Satoshi-Sh
left a comment
Satoshi-Sh
left a comment
There was a problem hiding this comment.
Looks great. Thanks for the restructuring the CardColumns folder. The Interface file kind of confused me but now it's simple and straightforward. 🎉
mtkksk1780
approved these changes
Aug 21, 2025
Member
mtkksk1780
left a comment
mtkksk1780
left a comment
There was a problem hiding this comment.
Thanks for the update! The CardsColumns component is well-organized and helps reduce the number of files. As a first-timer, I find that this refactor makes the card placement logic much clearer and easier to understand.
shayla-develops-webs
approved these changes
Aug 22, 2025
Member
shayla-develops-webs
left a comment
shayla-develops-webs
left a comment
There was a problem hiding this comment.
Looks good! This is actually giving me a good framework to refactor the card components!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you updated the CHANGELOG.md file? If not, please do it.
Yes
What is this change?
CardColumnsfrom Styled Components to CSS Modules.CardsColumnsInterfacetoCardsColumns.Were there any complications while making this change?
No
How to replicate the issue?
N/A (PR is a style migration)
If necessary, please describe how to test the new feature or fix.
Compare the card columns on the
mainandrefactor/to-scss-cardcolumnsbranches. The two should have the same style.When should this be merged?
After three approved reviews.