Removed Styled Components#294
Merged
Satoshi-Sh merged 4 commits intomainfrom Sep 24, 2025
Merged
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cherylli
approved these changes
Sep 21, 2025
oluwatobiss
approved these changes
Sep 22, 2025
Member
oluwatobiss
left a comment
oluwatobiss
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Satoshi-Sh!
mtkksk1780
approved these changes
Sep 24, 2025
Member
mtkksk1780
left a comment
mtkksk1780
left a comment
There was a problem hiding this comment.
@Satoshi-Sh
Thank you for the refactoring! Every page looks great to me.
- Updated globals.scss with the styling on themeConfig.js. (I'm not sure I should use the font related variables to define them as some are not covered. Should I update/add the variables to cover all of them? Please give me advice.)
In my opinion, everything should ideally be covered with variables to ensure uniformity and enhance maintainability but I believe this is a very low priority so it doesn’t need to be updated right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you updated the CHANGELOG.md file? If not, please do it.
Yes
What is this change?
If necessary, please describe how to test the new feature or fix.
Please check the stylings of the website
I see some a bug on this update.
https://github.com/user-attachments/assets/04e5310e-1c90-4ea8-9d5d-523c369cd53f
^^This bug was fixed once I use the correct font-family
When should this be merged?
After reviews