-
Notifications
You must be signed in to change notification settings - Fork 0
apply Token function #38
base: master
Are you sure you want to change the base?
Conversation
Max-Levitskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rebase on master
- Fix pipeline problem
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| ngOnInit() { | ||
| this.route.fragment.subscribe((fragment: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to use AcitvatedRouteSnapshot instead of subscribing for a single value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. It was port but need to be changed.)
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test tests nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #39
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.