Closed
Conversation
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Mask/core into feat/seedless-onboarding-controller
…ler' into feat/seedless-onboarding-controller
…-onboarding-controller
Sync with upstream `feat/seedless-onboarding-controller` branch
…/seedless-onboarding-controller
chaitanyapotti
requested changes
May 14, 2025
Member
chaitanyapotti
left a comment
There was a problem hiding this comment.
https://github.com/MetaMask/toprf-secure-backup/issues/106
Need to wait until this issue is resolved.
4 tasks
mcmire
suggested changes
May 21, 2025
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
mcmire
reviewed
May 21, 2025
packages/seedless-onboarding-controller/tests/__fixtures__/topfClient.ts
Show resolved
Hide resolved
…nboardingControllerErrorMessage'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds new seedless onboarding controller. This controller allows MM extension and mobile users to login with google, apple accounts. This controller communicates with web3auth nodes + relies on toprf sdk (unreleased) to perform CRU operations related to backing up srps.
The full list of operations supported are as follows:
The controller also persists some data to the local encrypted vault similar to keyring controller. This vault is encrypted with user password and contains ek, sk related to toprf flow.
We also store backupHashes locally to showcase in settings page whether a srp is backed up or not
The following items are not included in this PR and will be included in the next one
References
Please refer to seedless onboarding feature narrative
Changelog
Checklist