minor optimization and undefined session handle #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshuchawla009
requested review from
ieow and
matthiasgeihs
and removed request for
matthiasgeihs
ieow
reviewed
Oct 2, 2024
src/mpcCoreKit.ts
Outdated
| } | ||
|
|
||
| // wait for prefetch completed before setup tkey | ||
| const [loginResponse] = await Promise.all([loginPromise, prefetchTssPublicKeys]); |
Member
Author
There was a problem hiding this comment.
not really, i think just for code clarify.
src/mpcCoreKit.ts
Outdated
| } | ||
|
|
||
| // wait for prefetch completed before setup tkey | ||
| const [loginResponse] = await Promise.all([loginPromise, prefetchTssPublicKeys]); |
Contributor
There was a problem hiding this comment.
not getting this. prefetchTssPublicKeys is not a promise, so Promise.all does not apply?
Member
Author
There was a problem hiding this comment.
ah, thanks for catching. mistyped the variable name. Just pushed a fix
Contributor
There was a problem hiding this comment.
ah, now i get it.
so we want prefetchTssPublicKeys to complete before we fetch the postbox key?
Member
Author
There was a problem hiding this comment.
yes, basically this was optimization done to create tss pub keys parallely with login to save time during tkey setup later.
matthiasgeihs
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.