Update known failures running s2wasm results in wasm-shell#1057
Merged
Update known failures running s2wasm results in wasm-shell#1057
Conversation
The two new failures are calling aboirt(). They back the last LKGR build: https://wasm-stat.us/builders/linux/builds/20068 So its hard to say when they started failing. It would be nice to attribute the new successes to certain bugfixes but I have not done that work yet.
jgravelle-google
approved these changes
Jun 20, 2017
Member
|
It looks like this broke the s2wasm tests. I saw them broken locally, bisected to this commit. Also, it looks like they broke on CI here, it says "2 of 4 checks passed"? @sbc100 |
Member
Author
|
Strange. Sorry I didn't realize this file was actually used outside of the wasm waterfall. Will revert. |
kripken
pushed a commit
that referenced
this pull request
Jun 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two new failures are calling aboirt(). They back the
last LKGR build: https://wasm-stat.us/builders/linux/builds/20068
So its hard to say when they started failing.