Conversation
… even type is unreachable
dschuff
reviewed
Jul 18, 2017
| // if we have a concrete type for the load, then we know the size of the mem operation and | ||
| // can validate it | ||
| if (type != unreachable) { | ||
| shouldBeEqual(getWasmTypeSize(type), 8U, curr, "8-byte mem operations are only allowed with 8-byte wasm types"); |
Member
There was a problem hiding this comment.
Don't we already have shouldBeEqualOrFirstIsUnreachable that does exactly this?
Member
Author
There was a problem hiding this comment.
It's similar, but that method is for comparing types. Here the first argument isn't the type, it's a computation based on the type, and it's invalid to do that computation if the type is unreachable (it asserts, as it is not valid to ask for the size of an unreachable type, only concrete types have sizes)
Member
|
But yes, this is what I had in mind, thanks. |
Member
|
Got it, thanks! I'm going to go ahead and merge this so I can rebase on top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for unreasonable sizes even if type is unreachable