Conversation
Closed
dschuff
approved these changes
Sep 18, 2017
| Walker(std::unordered_set<Expression*>& seen) : seen(seen) {} | ||
|
|
||
| void visitExpression(Expression* curr) { | ||
| if (seen.find(curr) == seen.end()) { |
Member
There was a problem hiding this comment.
Can you just do
if (seen.insert(curr).second) dupes.push_back(curr);
Member
Author
There was a problem hiding this comment.
I suppose, but I find the .second notation hard to read myself (a shame it's not .inserted). Is it just me?
Member
There was a problem hiding this comment.
No, I agree the API is ugly.
Could always do something like
bool inserted;
std::tie<std::ignore, inserted> = seen.insert(curr);
if (!inserted) dupes.push_back(curr);
Member
Author
There was a problem hiding this comment.
Thanks, I like that way, updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds validation for the tree structure in our IR, that each node must have exactly one parent, and so each node must appear exactly once and no more. Turns out we had some errors in that regard, one actual bug and one test bug, both fixed. Also added some docs to the readme.