optimize asm2wasm helper functions like i32-div #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are consistently handled regardless of whether we optimize in parallel or not
kripken
force-pushed
the
optimize-asm2wasm-helpers
branch
from
5115441 to
5268486
Compare
Member
Author
|
Re-worked after the landing of #1168. This adds a small api to get the list of added helper trapping functions, and uses that to optimize them. |
jgravelle-google
approved these changes
Oct 4, 2017
Contributor
jgravelle-google
left a comment
jgravelle-google
left a comment
There was a problem hiding this comment.
Nice, the API extensions to TrappingFunctionContainer and OptimizingIncrementalModuleBuilder lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They previously were added while already optimizing, so they weren't in the list to get optimized.
See #1168 (comment)