Add Builder::makeGlobal for nicer global creation #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
Oct 10, 2017
src/wasm-builder.h
Outdated
| } | ||
|
|
||
| // Module-level helpers | ||
| static Global* makeGlobal(Name name, WasmType type, Expression* init, bool mutable_) { |
Member
There was a problem hiding this comment.
you could make the last argument an enum, and then you wouldn't need the comments everywhere.
Member
Author
There was a problem hiding this comment.
Good idea, my instincts here were wrong.
Should the opposite of Mutable be NotMutable, or Immutable?
Member
Author
There was a problem hiding this comment.
Ok, also a search shows that's more common, updated.
dschuff
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.