Use 'BinaryenGlobalRef' for globals in binaryen-c#1270
Merged
kripken merged 1 commit intoWebAssembly:masterfrom Nov 8, 2017
Merged
Use 'BinaryenGlobalRef' for globals in binaryen-c#1270kripken merged 1 commit intoWebAssembly:masterfrom
kripken merged 1 commit intoWebAssembly:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
BinaryenImportRefbeing used for globals in the C-API, instead of using its own type.Because the change doesn't functionally affect binaryen.js, the respective JS binaries haven't been updated.
This is part of multiple PRs as previously tracked in #1261.