Conversation
kripken
commented
Nov 14, 2017
| console.log("BinaryenUnaryId: " + Binaryen.UnaryId); | ||
| console.log("BinaryenBinaryId: " + Binaryen.BinaryId); | ||
| console.log("BinaryenSelectId: " + Binaryen.SelectId); | ||
| console.log("BinaryenDropId: " + Binaryen.DropId); |
Member
Author
There was a problem hiding this comment.
this fix looks like the line was deleted by mistake before the merge to master somehow. not sure what happened there
Contributor
There was a problem hiding this comment.
test_ids() is relatively new (from #1269). Looks like I skipped DropId when it was initially created :(
Sometimes I am editing the tests by hand because I can't run them on Windows without spinning up a VM. Makes me feel guilty.
Member
Author
There was a problem hiding this comment.
Heh, no problem. Now at least I know what caused that ;)
kripken
commented
Nov 14, 2017
| [wasm-validator error in function $main] unexpected false: call target must exist, on | ||
| [none] (call $fn) | ||
| (perhaps it should be a CallImport instead of Call?) | ||
| (module |
Member
Author
There was a problem hiding this comment.
we don't print out module contents by default any more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in comments.