Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Dec 5, 2017

Some stuff I noticed when writing some algorithms from scratch using binaryen.js for fun:

  • The default type of a block should be none, not unreachable. This is technically a breaking change, but the previous way is just not good (and was not tested).
  • Allow a more spec-like notation, e.g. br as an alias for break, get_local as an alias for getlocal, etc., and add a br_if. This keeps backwards compatibility, both old and new ways work.

… and add text-format style aliases for things like getLocal (so you can write get_local as in the text format)
@kripken
Copy link
Member Author

kripken commented Dec 6, 2017

cc @dcodeIO

@dcodeIO
Copy link
Contributor

dcodeIO commented Dec 6, 2017

LGTM (never relied on binaryen.undefined as the default in blocks)

@kripken kripken merged commit 22f1ce8 into master Dec 7, 2017
@kripken kripken deleted the sieve branch December 7, 2017 17:56
dcodeIO added a commit to AssemblyScript/binaryen.js that referenced this pull request Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants