Skip to content

Also clear imports and exports maps in BinaryenModuleDispose #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 5 commits into from
Jan 19, 2018
Merged

Also clear imports and exports maps in BinaryenModuleDispose #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47a0867
Also clear imports and exports maps in BinaryenModuleDispose, fixes #…
dcodeIO Jan 18, 2018
c1abad2
Auto-update-tests
dcodeIO Jan 19, 2018
129dbff
Trigger CI
dcodeIO Jan 19, 2018
a599bbb
Merge remote-tracking branch 'webassembly/master' into c-fix-clear-im…
dcodeIO Jan 19, 2018
0e6f9f4
Update binaries and kitchen-sink test
dcodeIO Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions bin/binaryen.js
View file
Open in desktop

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions bin/wasm.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/binaryen-c.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ void BinaryenModuleDispose(BinaryenModuleRef module) {
functionTypes.clear();
expressions.clear();
functions.clear();
imports.clear();
exports.clear();
relooperBlocks.clear();
}

Expand Down
2 changes: 1 addition & 1 deletion test/binaryen.js/kitchen-sink.js.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2033,7 +2033,7 @@ getExpressionInfo(f64.const)={"id":15,"type":4,"value":9.5}
BinaryenType paramTypes[] = { 1 };
functionTypes[1] = BinaryenAddFunctionType(the_module, "vi", 0, paramTypes, 1);
}
imports[1] = BinaryenAddFunctionImport(the_module, "check", "module", "check", functionTypes[1]);
imports[0] = BinaryenAddFunctionImport(the_module, "check", "module", "check", functionTypes[1]);
the_relooper = RelooperCreate();
expressions[1] = BinaryenConst(the_module, BinaryenLiteralInt32(1337));
{
Expand Down
2 changes: 1 addition & 1 deletion test/example/c-api-kitchen-sink.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1988,7 +1988,7 @@ int main() {
BinaryenType paramTypes[] = { 1 };
functionTypes[1] = BinaryenAddFunctionType(the_module, "vi", 0, paramTypes, 1);
}
imports[1] = BinaryenAddFunctionImport(the_module, "check", "module", "check", functionTypes[1]);
imports[0] = BinaryenAddFunctionImport(the_module, "check", "module", "check", functionTypes[1]);
the_relooper = RelooperCreate();
expressions[1] = BinaryenConst(the_module, BinaryenLiteralInt32(1337));
{
Expand Down