better handling of float ops in wasm2asm #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
These changes don't require updates in the existing wasm2asm tests? |
We weren't handling them before, but it wasn't obvious. Make the (non-) handling of them explicit in the code. We'll add handlers for them shortly.
min, max, and copysign will require more sophisticated handling.
It was previously grouped with the i32 ops.
froydnj
force-pushed
the
binary-float-handling
branch
from
e9983bc to
12bd93d
Compare
Contributor
Author
Good point, added tests for translating everything (no assertions yet, though). The asm.js looks a little funny (multiple returns, for instance), but that can be handled in a followup. |
kripken
reviewed
Feb 15, 2018
|
|
||
| } | ||
|
|
||
| function $$1($$0, $$1) { |
Member
There was a problem hiding this comment.
btw, it would be nice to have wasm2asm emit proper function names (same name as in the wasm)
Contributor
Author
There was a problem hiding this comment.
For ease of debugging?
Member
There was a problem hiding this comment.
Yeah, I think it would help debugging and also reading the testcases.
Member
There was a problem hiding this comment.
Maybe we should only do it with -g or something like that?
Member
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
wasm2asmon files intest/revealed some errors in handling float operations. This pull request is a first attempt at handling them. More complex operations, like conversion, reinterpretation, and copysign, are left for later.