Fail fast #1578
Merged
Fail fast #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of the commands in the build script fail we don't want to continue. Travis should really provide and option for this and it should probably be the default: travis-ci/travis-ci#1066 Fixes #1559
dschuff
reviewed
May 31, 2018
auto_update_tests.py
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import XXXXX |
Member
There was a problem hiding this comment.
I guess this was just for testing?
Member
Author
There was a problem hiding this comment.
Indeed, verified early fail and now reverted.
dschuff
approved these changes
May 31, 2018
Member
|
Thanks @sbc100 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.