Skip to content

Fix out-of-tree install of wasm.js #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Jul 6, 2018
Merged

Fix out-of-tree install of wasm.js #1616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ INSTALL(FILES src/binaryen-c.h DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

# if binaryen.js and wasm.js were built (using "./build-js.sh", currently
# optional), install them
IF(EXISTS "bin/binaryen.js")
IF(EXISTS "${CMAKE_SOURCE_DIR}/bin/binaryen.js")
INSTALL(FILES bin/binaryen.js DESTINATION ${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
Copy link
Member

@kripken kripken Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, don't we also need the prefix for bin/binaryen.js on this line as well (and below)?

Copy link
Member

@kripken kripken Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, reading the docs again I see this is fine as it is, lgtm.

ENDIF()
IF(EXISTS "bin/wasm.js")
IF(EXISTS "${CMAKE_SOURCE_DIR}/bin/wasm.js")
INSTALL(FILES bin/wasm.js DESTINATION ${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
ENDIF()

Expand Down