wasm-emscripten-finalize: separateDataSegments() fix #1897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith only the data segments, starting from the global base
jgravelle-google
approved these changes
Feb 6, 2019
kripken
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Feb 7, 2019
* Fix emcc.py setting of memoryInitializer URL - we just need to set the url there (while the asm2wasm path also fetches the binary data out of the js). * Make `pthread_exit` throw, to halt execution - the wasm backend optimizes based on it being `noReturn`. * Implement some basic JS support, `establishStackSpace` and some `Atomics_*` aliases. * If wasm backend, avoid the `also_asmjs` path in the test runner, which would check asm.js in addition to wasm. * Implement `system/lib/pthread/library_pthread_wasm.c`, which provides the `emscripten_atomic_*` APIs, which I believe represent the original SIMD.js spec reflected into JS. Perhaps we don't really need this in the long term, but there are tests for it, and I think maybe the pthreads runtime uses it. Note: I didn't check this very carefully, and haven't run the tests on it yet. With this PR + [WebAssembly/binaryen#1897](WebAssembly/binaryen#1897) we get hello world printing properly in a pthreads build, and also some pthreads tests pass, like e.g. `browser.test_pthread_join`, but others do not, so this does not yet enable any tests on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should emit a file with only the data segments, starting from the global base, and not starting from zero (the data before is unneeded, and the emscripten loading code assumes it isn't there).
Also fix the auto updater to work properly on
.memtest updating.