Skip to content

Fix typo in C API#2047

Merged
kripken merged 1 commit intoWebAssembly:masterfrom
turbolent:patch-1
Apr 24, 2019
Merged

Fix typo in C API#2047
kripken merged 1 commit intoWebAssembly:masterfrom
turbolent:patch-1

Conversation

@turbolent
Copy link
Copy Markdown
Contributor

The function BinaryeGlobalImportGetModule should be called BinaryenGlobalImportGetModule (missing n), leading to a linking error, as the function is called properly called BinaryenGlobalImportGetModule:

const char* BinaryenGlobalImportGetModule(BinaryenGlobalRef import) {

@kripken
Copy link
Copy Markdown
Member

kripken commented Apr 24, 2019

Thanks @turbolent!

We should have more comprehensive tests for these things eventually...

@kripken kripken merged commit bc0a605 into WebAssembly:master Apr 24, 2019
@turbolent turbolent deleted the patch-1 branch April 25, 2019 03:07
@turbolent
Copy link
Copy Markdown
Contributor Author

@kripken no worries!

I'm working on a Swift wrapper and it's a real pleasure to wrap such a comprehensive API. Thank you for the great work!

@kripken
Copy link
Copy Markdown
Member

kripken commented Apr 25, 2019

@turbolent nice, very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants