Fix typo in C API#2047
Merged
kripken merged 1 commit intoWebAssembly:masterfrom Apr 24, 2019
turbolent:patch-1
Merged
Conversation
Member
|
Thanks @turbolent! We should have more comprehensive tests for these things eventually... |
Contributor
Author
|
@kripken no worries! I'm working on a Swift wrapper and it's a real pleasure to wrap such a comprehensive API. Thank you for the great work! |
Member
|
@turbolent nice, very cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
BinaryeGlobalImportGetModuleshould be calledBinaryenGlobalImportGetModule(missingn), leading to a linking error, as the function is called properly calledBinaryenGlobalImportGetModule:binaryen/src/binaryen-c.cpp
Line 2866 in 9495b33