Delete WasmBinaryBuilder::mappedGlobals (NFC)#2098
Merged
aheejin merged 1 commit intoWebAssembly:masterfrom May 12, 2019
Merged
Delete WasmBinaryBuilder::mappedGlobals (NFC)#2098aheejin merged 1 commit intoWebAssembly:masterfrom
aheejin merged 1 commit intoWebAssembly:masterfrom
Conversation
It doesn't seem to be used anywhere and I don't know why the implementation for `WasmBinaryBuilder::getGlobalName` and `WasmBinaryBuilder::getFunctionIndexName` are different. Renamed `getFunctionIndexName` to `getFunctionName` for consistency.
kripken
approved these changes
May 12, 2019
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Thanks! Very good to clean this up.
I think this looked like it did because we used to have separate Import objects, so handling globals and functions was tricky. But then we moved to functions and globals objects that represent either an imported or a defined function or global. And I guess we forgot to clean up the globals code here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't seem to be used anywhere and I don't know why the
implementation for
WasmBinaryBuilder::getGlobalNameandWasmBinaryBuilder::getFunctionIndexNameare different. RenamedgetFunctionIndexNametogetFunctionNamefor consistency.