Add missing methods for globals to binaryen.js#2099
Merged
aheejin merged 1 commit intoWebAssembly:masterfrom May 13, 2019
Merged
Add missing methods for globals to binaryen.js#2099aheejin merged 1 commit intoWebAssembly:masterfrom
aheejin merged 1 commit intoWebAssembly:masterfrom
Conversation
aheejin
changed the title
- Print `globals` array in the tracing mode like other arrays (`functions`, `exports`, `imports`, ...) - Add accessor functions for globals
kripken
approved these changes
May 13, 2019
aheejin
added a commit
to aheejin/binaryen.js
that referenced
this pull request
May 14, 2019
This adds missing members to getGlobalInfo, to sync with WebAssembly/binaryen#2099.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
globalsarray in the tracing mode like other arrays(
functions,exports,imports, ...)