allow color API to enable and disable colors#2111
Merged
kripken merged 1 commit intoWebAssembly:masterfrom May 17, 2019
tweag:may-16-provide-finer-grained-color-API
Merged
allow color API to enable and disable colors#2111kripken merged 1 commit intoWebAssembly:masterfrom tweag:may-16-provide-finer-grained-color-API
kripken merged 1 commit intoWebAssembly:masterfrom
tweag:may-16-provide-finer-grained-color-API
Conversation
kripken
reviewed
May 16, 2019
| return NULL; | ||
| } | ||
|
|
||
| void BinaryenSetColosrEnabled(int enabled) { Colors::setEnabled(enabled); } |
Member
|
Have you joined the w3c group (which we require from contributors)? For a test, you can add a program in |
Contributor
Author
|
Yes, I just joined the WebAssembly community group: https://www.w3.org/community/webassembly/participants (Siddharth Bhat) |
This is useful for front-ends which wish to selectively enable or disable coloring. Also expose these APIs from the C API.
Member
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for front-ends which wish to selectively enable or
disable coloring.
Also expose this API through the C API