Disable clang static analyzer in clang-tidy#2136
Merged
aheejin merged 1 commit intoWebAssembly:masterfrom May 23, 2019
Merged
Conversation
clang-tidy by default enables two groups of checks: clang-diagnostic-* and clang-analyzer-*. Between the two, clang-analyzer is a static analyzer, but it seems to often produces false warnings. For example, when you write `object->someFunction()`, if it is not sure if object is not a NULL, i.e., if there's no assert(object) before, it produces a warning. This is sometimes annoying and inserting `assert` everywhere does not seem to be very appealing. I also noticed LLVM and V8 also disabled this analyzer. `-*` disables all checks. Then I re-enabled clang-diagnostic and readability-braces-around-statements.
kripken
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-tidy by default enables two groups of checks: clang-diagnostic-*
and clang-analyzer-*. Between the two, clang-analyzer is a static
analyzer, but it seems to often produces false warnings. For example,
when you write
object->someFunction(), if it is not sure if object isnot a NULL, i.e., if there's no assert(object) before, it produces a
warning. This is sometimes annoying and inserting
asserteverywheredoes not seem to be very appealing. I also noticed LLVM and V8 also
disabled this analyzer.
-*disables all checks. Then I re-enabled clang-diagnostic andreadability-braces-around-statements.