Conversation
…sues with stack sizes on Mac
dschuff
approved these changes
Jun 1, 2019
|
|
||
| struct SeekState { | ||
| Expression* curr; | ||
| int mul; |
Member
There was a problem hiding this comment.
I guess this is pre-existing, but is 'mul' short for 'multiplier'? Could we maybe spend a few of our 80 columns and spell it out?
Member
There was a problem hiding this comment.
oh, it makes more sense if you expand and read the function comment. either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps avoid issues with smaller stack sizes on some OSes.
Should fix the last Mac test failure on emscripten-releases CI (
other.test_js_function_names_are_minified, which happens to have massively-nested additions of constants).