Use splatted zero vector in makeZero#2164
Merged
tlively merged 2 commits intoWebAssembly:masterfrom Jun 6, 2019
Merged
Conversation
This prevents the optimizer from producing v128.const instructions, which are not supported by V8 at this time.
kripken
approved these changes
Jun 6, 2019
| } | ||
|
|
||
| inline Expression* makeZero(Type type, Module& wasm) { | ||
| // TODO: Switch to using v128.const once V8 supports it |
Member
There was a problem hiding this comment.
is there a bug number we can add in a link here?
do other impls support it? if so can mention that in the comment too, as when we change this may depend on those too.
Member
Author
There was a problem hiding this comment.
Added a link. All other implementations that implement any SIMD implement this instruction (https://github.com/WebAssembly/simd/blob/master/proposals/simd/ImplementationStatus.md), so we should only have to worry about V8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the optimizer from producing v128.const instructions,
which are not supported by V8 at this time.