Conversation
…ess it. * Fix builder bug with makeExport.
sbc100
approved these changes
Jul 1, 2019
Member
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm (.. not that fully grok of this)
| auto* export_ = new Export(); | ||
| export_->name = name; | ||
| export_->value = value; | ||
| export_->kind = ExternalKind::Function; |
Member
There was a problem hiding this comment.
This bugfix seems like it would have a bigger effect.
Member
Author
There was a problem hiding this comment.
Yeah, I think what happened is the code was copy-pasted from one place that did this (for functions). It wasn't used in another place til now...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets fuzzing support for Bysyncify working.