wasm-emscripten-finalize: Internalize mutable __stack_pointer import#2213
Merged
wasm-emscripten-finalize: Internalize mutable __stack_pointer import#2213
Conversation
I'm working on a change to lld that will cause `-pie` binaries to import __stack_pointer, just like -shared do already. Because we don't yet support mutable globals everywhere this change will internalize the import and create a new immutable import that is used to initialize the internal one. This change is part of the fix for: emscripten-core/emscripten#8915
kripken
approved these changes
Jul 10, 2019
| // and restore functions. | ||
| void replaceStackPointerGlobal(); | ||
|
|
||
| // Remove the import of a mutable __stack_pointer and instead initialze the |
| } | ||
|
|
||
| Name internalName = stackPointer->name; | ||
| Name externalName = internalName.c_str() + std::string("_import"); |
Member
There was a problem hiding this comment.
how about adding an assert that stackPointer->imported(), I think that might help readability too?
Member
Author
There was a problem hiding this comment.
There is an early return above when its not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a change to lld that will cause
-piebinaries toimport __stack_pointer, just like -shared do already. Because we
don't yet support mutable globals everywhere this change will
internalize the import and create a new immutable import that is used
to initialize the internal one.
This change is part of the fix for:
emscripten-core/emscripten#8915