Conversation
This is core import like __memory_base and __table_base.
| auto process = [&](Name& name) { | ||
| // do not minifiy special imports, they must always exist | ||
| if (name == MEMORY_BASE || name == TABLE_BASE) { | ||
| if (name == MEMORY_BASE || name == TABLE_BASE || name == STACK_POINTER) { |
There was a problem hiding this comment.
are these "ABI imports" documented in tool-conventions? if so a link to there might be nice.
for the first two I think the dynamic linking doc there mentions them.
There was a problem hiding this comment.
I don't know .. all i know is that if I allow minification of __stack_pointer I get a test failure. To be honest I'm not sure why these can't be minified too.
There was a problem hiding this comment.
Oh you are correct this should be documented in https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md but isn't yet.
|
Any idea why binaryen travis checks take so long? It seems like we should be able to get good test coverage in less than an hour. |
|
Binaryen's travis is shared with all other |
2 participants
This is core import like __memory_base and __table_base.