Enable all features in wasm-shell assert failure tests#2254
Merged
aheejin merged 1 commit intoWebAssembly:masterfrom Jul 26, 2019
Merged
Enable all features in wasm-shell assert failure tests#2254aheejin merged 1 commit intoWebAssembly:masterfrom
aheejin merged 1 commit intoWebAssembly:masterfrom
Conversation
If we don't enable features in assertion failure tests, new feature tests fail not because they are malformed but because they have unsupported features. It's hard to add tests because existing `assert_invalid` tests were already failing because they have unsupported features.
Member
|
How does the spec test suite handle this? Do they also assume all features are always present (no tests for a feature not being present)? If they also assume that then lgtm. |
Member
Author
|
I searched and couldn't find any tests that tests for feature enabling/disabling. It is not even possible currently because |
Member
Author
|
I guess it's ok to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't enable features in assertion failure tests, new feature
tests fail not because they are malformed but because they have
unsupported features. It's hard to add tests because existing
assert_invalidtests were already failing because they haveunsupported features.