Merged
Conversation
This adds - `push`/`pop` support for other types: v128 and exnref - `push`/`pop` support for binaryen.js Because binaryen.js follows Binaryen's AST structure, without `pop` in binaryen.js, EH instructions cannot be represented in binaryen.js.
tlively
approved these changes
Jul 25, 2019
| } | ||
| BinaryenExpressionRef BinaryenPush(BinaryenModuleRef module, | ||
| BinaryenExpressionRef value) { | ||
| auto* ret = Builder(*((Module*)module)).makePush((Expression*)value); |
Member
There was a problem hiding this comment.
I think there is an extra set of parens around (Module*)module.
Member
Author
There was a problem hiding this comment.
You're right. By the way I actually copy-pasted from other functions, so maybe we can remove all of them. Anyway here I'll remove them.
kripken
approved these changes
Jul 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
push/popsupport for other types: v128 and exnrefpush/popsupport for binaryen.jsBecause binaryen.js follows Binaryen's AST structure, without
popinbinaryen.js, EH instructions cannot be represented in binaryen.js.