Conversation
|
Landing quickly as this blocks testing more interesting things with wasi on our CI, and is probably noncontroversial, but please review later. |
| extern Name EVENT; | ||
| extern Name ATTR; | ||
| extern Name WASI; | ||
| extern Name WASI_UNSTABLE; |
There was a problem hiding this comment.
These probably don't belong in a header unless they are at least used by multiple source files.
There was a problem hiding this comment.
I think one of my next PRs will use them, as I add more wasi support. If it turns out no then I can remove these.
| Name EVENT("event"); | ||
| Name ATTR("attr"); | ||
| Name WASI("wasi"); | ||
| Name WASI_UNSTABLE("wasi_unstable"); |
There was a problem hiding this comment.
It premature to add WASI here, unless I'm missing something. The plan is not to go from wasi_unstable to just wasi, but rather split it into modules.
There was a problem hiding this comment.
Oh, I didn't know that, will fix.
| module->updateMaps(); | ||
| // Emit the mapping. | ||
| for (auto& pair : oldToNew) { | ||
| for (auto& pair : newToOld) { |
There was a problem hiding this comment.
Why are you now outputting the mapping in reverse?
There was a problem hiding this comment.
The code was actually wrong before - it was called oldToNew but had the opposite data ;) This PR also corrects that.
2 participants
This makes the minification pass aware of
wasi_unstableandwasias well.